This patch attempts to fix bug 195935

Mark Kretschmann kretschmann at kde.org
Wed Oct 21 09:29:09 CEST 2009


On Wed, Oct 21, 2009 at 7:03 AM, Victor W <victor.w at pervices.com> wrote:
> The attached patch attempts to fix Bug 195935:   remaining time of long
> tracks gets cut off

Thanks Victor, I've pushed your patch to git master.


> +    void setNomWidth( int nomWidth )
> +    {
> +        if( nomWidth > 0)
> +        {
> +         m_nomWidth = nomWidth;
> +         QWidget::setFixedWidth( m_nomWidth );
> +        }
> +    }

Two tips for future contributions:

1) Please don't use cryptic function/member names like "nomWidth".
It's very hard to tell what it means.
2) Please heed our code formatting style. See
amarok/HACKING/intro_and_style.txt.

Thanks :)


-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org


More information about the Amarok-devel mailing list