background-color of the lyrics-applet
Martin
darklight.xdarklight at googlemail.com
Sun Oct 18 20:22:29 CEST 2009
Hi,
> Am Sunday 18 October 2009 schrieben Sie:
> > anyhow, I still have one question:
> > why are you using the 'Highlight' color as base color (which you are
> > modifying then)?
>
> Because it's the closest match (the background is a shade of the highlight
> color and /not/ the window color at all, nor is the widget "transparent",
> i.e. setAutofillBackground(false))
>
I see
> > wouldn't it be better to use the color schemes 'Background' color as base
> > and modify that one?
>
> just to clarify:
> that's not my stuff at all and using the highlight color in base areas is
> -ui designwise spoken- a stupid idea.
> Highlight colors are supposed to be eye catchers and should not be used as
> general and standard backgrounds - setting the value doesn't make things
> better as the color value equals the strongest component, ie. eg. Qt::red
> allready /has/ a value of 0xff or 1.0
>
> However, /if/ one really wants to use the (shaded) highlight color as
> background it should also be set as background role to indicate that this
> widget does /not/ have a window colored background at all (e.g. if the
> background color was set to a mix of 80% window color and 20% highlight
> color, i'd rank it window colored, and thus leave or set the background
> role to QPalette::Window)
>
> The "proper" backgroundRole in this regard should however be QPalette::Base
> and be an unmodified variant of the app wide QPalette::Base color (i.e. no
> palette maipulation at all) - but this is /not/ my decision :-(
>
> > [2] http://pastebin.ca/1627124
>
> If the PaletteHandler class is a global one, i'd maybe use a less generic
> name for that routine (like "setWidgetBackgroundToShadedHighlight" or so)
>
> Regards,
> Thomas
ok, sounds like some ui magician should put his hands on this (that means I'm
out :))
Regards,
Martin
More information about the Amarok-devel
mailing list