[Amarok] Don't try to download images when offline.

Bart Cerneels bart.cerneels at kde.org
Sun Nov 15 22:54:56 CET 2009


On Sun, Nov 15, 2009 at 21:53, Seb Ruiz <ruiz at kde.org> wrote:
> 2009/11/16 Bart Cerneels <bart.cerneels at kde.org>:
>> commit af85411d469432812506fd5d82172b22aa30daf9
>> Author:     Bart Cerneels <bart.cerneels at kde.org>
>> AuthorDate: Sun Nov 15 17:32:37 2009 +0100
>> Commit:     Bart Cerneels <bart.cerneels at kde.org>
>> CommitDate: Sun Nov 15 17:34:47 2009 +0100
>>
>>    Don't try to download images when offline.
>>
>> diff --git a/src/podcasts/PodcastImageFetcher.cpp b/src/podcasts/PodcastImageFetcher.cpp
>> index 60c9cde..d812ef2 100644
>> --- a/src/podcasts/PodcastImageFetcher.cpp
>> +++ b/src/podcasts/PodcastImageFetcher.cpp
>> @@ -20,6 +20,7 @@
>>
>>  #include <KIO/Job>
>>  #include <KMD5>
>> +#include <Solid/Networking>
>>
>>  PodcastImageFetcher::PodcastImageFetcher()
>>  {
>> @@ -84,6 +85,13 @@ PodcastImageFetcher::run()
>>         return;
>>     }
>>
>> +    if( Solid::Networking::status() != Solid::Networking::Connected )
>> +    {
>
> What will happen on windows where Solid isn't present? Will it return
> connected or disconnected?
>
> --
> Seb Ruiz

It should return Unknown, which I should just consider "don't know"
and keep downloading. Haven't gotten around to that today.


More information about the Amarok-devel mailing list