Implementation of the "Custom Tags" Feature

[Maximilian Kossick]

I agree with Jeff. Adding the labels SQL code to TagDialog is definitely wrong.

the logical place to put the label management code is a Capability in
my opinion. Adding support for labels to querymaker is going to be
interesting to say the least, especially as we probably should move
the label queries for SQL based collections into the actual SQL
queries for performance reasons. And as MySQL supports sub queries
(unlike Sqlite) we can use sub queries. Please do not use the left
joins of the A1 labels queries as an example, those never worked right
for complex queries.

On Wed, Nov 4, 2009 at 7:58 PM, Jeff Mitchell <mitchell at kde.org> wrote:
> OK, some comments.
>
> First, I'm worried about adding all of this to the Tag Dialog when a lot
> of us are feeling like the Tag Dialog is crufty and needs to be
> rewritten anyways.
>
> Second, those various SQL statements should not live in the Tag Dialog.
> They need to be moved to the Sql Collection. There are other places
> around Amarok that have embedded SQL, but they're in the wrong. I think
> we should attempt to have new code do it right.

there are places where embedding SQL makes sense (e.g.
ServiceSqlCollection). TagDialog is not one of them, I agree.

> --Jeff
>
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>