Implementation of the "Custom Tags" Feature

[Daniel Dewald]

On Wednesday, 4. November 2009 19:27:59 Mark Kretschmann wrote:
> On Wed, Nov 4, 2009 at 7:17 PM, Ian Monroe <ian.monroe at gmail.com> wrote:
> > On Wed, Nov 4, 2009 at 12:04 PM, Mark Kretschmann <kretschmann at kde.org> 
wrote:
> >> On Wed, Nov 4, 2009 at 6:49 PM, Daniel Dewald
> >>
> >> <Daniel.Dewald at time-shift.de> wrote:
> >>> My preliminary Implementation of custom label support is completed. So
> >>> far I've implemented the Gui to add/remove and edit the labels for a
> >>> track or multiple tracks and created the underlying functions to
> >>> write/read the labels from and to the Database. Some preliminary
> >>> testing was also done by me. I'd like to invite everybody who is
> >>> interested in this feature to test/verify my code and the
> >>> implementation and inform me if anything isn't as it should be. So far
> >>> the labels are not good for anything real other then tagging itself.
> >>> Search and playlist functions will be added asap.
> >>
> >> Daniel, ideally please make a Merge Request instead of sending a patch:
> >>
> >> http://gitorious.org/amarok/amarok/merge_requests
> >
> > Well once he wants to merge.
> >
> > In the mean time, please just email us the repo url. :)
> 
> I prefer Merge Requests anyway.
> 
> First of all, we don't have to merge immediately. Could wait forever
> in fact. Second, the Merge Request system on Gitorious allows us to
> make comments regarding the patch, then the contributor can refine,
> rinse, repeat. Third, I find that much more convenient than checking
> out some clone. YMMV.
> 

I issued a merge request. I just thought since we're in a string freeze its 
would be kind of useless. I stand corrected ;). 

http://gitorious.org/~thecrasher/amarok/thecrashers-sandbox

-- 
Time-Shift Entertainment
Daniel Dewald
Im Ginselt 8
66709 Weiskirchen
https://www.time-shift.de/

Zertifikat:
https://www.time-shift.de/Certificates/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3063 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20091104/363be1c1/attachment.p7s