extragear/multimedia/amarok/src/context/applets/currenttrack

Mark Kretschmann kretschmann at kde.org
Tue Mar 3 09:54:58 CET 2009


SVN commit 934480 by markey:

Get rid of the style-sheet for the Plasma::TabBar again. It produced
artifacts, and looked totally broken on Nightrose's box:

http://lydiapintscher.de/tmp/nowplaying.jpeg

Now what to do? The stock Plasma::TabBar is one pile of ugly with
Oxygen, and looks like a slider widget (irritating).

CCMAIL: amarok-devel at kde.org

 M  +1 -2      CurrentTrack.cpp  


--- trunk/extragear/multimedia/amarok/src/context/applets/currenttrack/CurrentTrack.cpp #934479:934480
@@ -130,7 +130,6 @@
     m_noTrack->setText( m_noTrackText );
     
     m_tabBar = new Plasma::TabBar( this );
-    m_tabBar->setStyleSheet( "TabBar::tab { border-radius: 4px; }" ); // Makes the TabBar look differently, with round borders 
 
     for( int i = 0; i < MAX_PLAYED_TRACKS; i++ )
     {
@@ -263,7 +262,7 @@
         m_tracksToShow = qMin( m_lastTracks.count(), ( int )( ( contentsRect().height() - 30 ) / ( textHeight * 1.2 ) ) );
 
         QFontMetrics fm( m_tabBar->font() );
-        m_tabBar->resize( QSizeF( contentsRect().width() - margin * 2 - 2, m_tabBar->size().height() ) ); 
+        m_tabBar->resize( QSizeF( contentsRect().width() - margin * 2 - 2, m_tabBar->size().height() * 0.7 ) ); // Why is the height factor ignored?
         m_tabBar->setPos( size().width() / 2 - m_tabBar->size().width() / 2 - 1, 10 );
         m_tabBar->show();
         


More information about the Amarok-devel mailing list