extragear/multimedia/amarok

[Soren Harward]

On Fri, Jun 26, 2009 at 12:36 PM, Jeff Mitchell<mitchell at kde.org> wrote:
> Ian, Alejandro and myself (at least) have multiple reservations about the changes made in this patch.  It needs review and testing before being pushed out to trunk, especially as it updates the database (in a way
> that is probably not correct).  This really needs to be put in a git branch first and tested out, or submitted as a patch to the mailing list for review.

Here's the patch against r987764.

But I'd like to point out that this isn't the first time I've
submitted a patch to the ML for review.  I'm fine with it being
reviewed before it gets committed.  But I'm not fine with people
saying it must be reviewed before it gets committed, and then nobody
ever reviewing it (especially those who insist on a review), and thus
never letting me commit it.

Comments please.

-- 
Soren Harward
-------------- next part --------------
A non-text attachment was scrubbed...
Name: acoustic_fingerprints.patch.gz
Type: application/x-gzip
Size: 16896 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090626/e2886cd7/attachment-0001.gz