extragear/multimedia/amarok
Seb Ruiz
ruiz at kde.org
Fri Jun 26 01:29:35 CEST 2009
2009/6/26 Jeff Mitchell <mitchell at kde.org>:
> Gary David Steinert wrote:
>> SVN commit 987339 by gsteinert:
>>
>> Another uber-mega commit. Fixed problems with *'s not lining up at end of lines.
>> Also included a check for this in the licenseChecker program
>> M +25 -3 utilities/licenseChecker/main.cpp
>
> I didn't notice it before now, or I would have said something sooner --
> I don't think licenseChecker belongs in utilities. It's really an
> internal tool, and has no purpose or business being installed as part of
> Amarok on a user's system.
>
> It should go in one of the scripts dirs that gets pruned out when we
> release. Actually, it should be disabled in CMakeLists.txt until
> someone explicitly needs it and enables it. Or both.
>
> (If it is already that way w.r.t CMakeLists, ignore me -- but I still
> say the location is wrong.)
Infact I'd put it in kde scripts.
--
Seb Ruiz
http://www.sebruiz.net/
http://amarok.kde.org/
More information about the Amarok-devel
mailing list