Fwd: kdesupport/phonon/gstreamer

[Seb Ruiz]

Guys, we're getting through!


---------- Forwarded message ----------
From: Jens Bache-Wiig <jbache at trolltech.com>
Date: 2009/2/28
Subject: kdesupport/phonon/gstreamer
To: kde-commits at kde.org


SVN commit 932980 by jbache:

Phonon/GStreamer: Preliminary workaround for buggy volumefader

Amarok makes use of the volumefader. While this is sub-optimal in the
current GStreamer implementation as swapping elements dynamically introduces
an audible gap, this fix will ensure that we resume to the pending state and
not the current state which could mean that pressing the stop-button would
get ignored.



 M  +2 -2      mediaobject.cpp


--- trunk/kdesupport/phonon/gstreamer/mediaobject.cpp #932979:932980
@@ -141,9 +141,9 @@
    if (m_resumeState)
        return;

-    if (m_state == Phonon::PlayingState || m_state == Phonon::PausedState) {
+    if (m_pendingState == Phonon::PlayingState || m_pendingState ==
Phonon::PausedState) {
        m_resumeState = true;
-        m_oldState = m_state;
+        m_oldState = m_pendingState;
        m_oldPos = getPipelinePos();
    }
 }



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/