Patch to make Ampache server work with 3.4.x and 3.5.x Authentication models

Ian Monroe ian.monroe at gmail.com
Wed Feb 18 04:34:48 CET 2009


On Tue, Feb 17, 2009 at 5:27 PM, Karl Vollmer <vollmer at ampache.org> wrote:
> Attached is a svn diff that should allow Amarok2 to authenticate to
> 3.4.x and 3.5.x Ampache servers. The Ampache service now requires QCA2
> due to the use of SHA256() Thanks a to nhnFreespirit for working his
> cmake-fu on the QCA2 cmake stuff.
>
> This patch works by attempting to get a results set from
> /xml.server.php?action=ping which is only valid on Ampache >=3.5.0. If
> no valid response is returned the version is set to 10000, otherwise
> the version is defined by the XML response. Using the version it
> determines if it should use MD5() or SHA256().
>
> This patch does not address the changes / new features in the 3.5.x
> API however 3.4.x calls will work against 3.5.x so it should continue
> to work for the foreseeable future... Until I break the Ampache end.
>
> -Karl

First off, I think we should just get you a KDE SVN account. None of
this apply your patch nonsense. :D

I'm not sure about depending on QCA2 just for one function, though
it's a fairly common dependency (I think kdepim uses it). I think its
fine to commit requiring it, but swapping it out with just a
copy-and-paste SHA256 function wouldn't be a bad idea in the future.

Ian


More information about the Amarok-devel mailing list