[Amarok] improved filtering in the collection browsers, no

Maximilian Kossick maximilian.kossick at googlemail.com
Wed Dec 23 08:43:39 CET 2009


On Wed, Dec 23, 2009 at 1:22 AM, Jeff Mitchell <mitchell at kde.org> wrote:
> On 12/22/2009 5:13 PM, Casey Link wrote:
>>> Both the view and querymaker work correctly from what I can see. What
>>> is not working correctly is that SqlCollectionLocation::remove() a)
>>> removes the wrong row from the tracks table(it should be WHERE url =
>>> %1 instead of WHERE id = %1 ... again) and b) does not clear all the
>>> other tables (e.g. artists, albums, ...) when necessary.
>>
>> Thanks for the quick response!
>>
>> Just to be clear the query should be:
>> "DELETE FROM tracks where url = %1;"   where %1 is the id?
>>
>> Also, aren't there foreign key constraints to remove artists/albums
>> when tracks are deleted?
>
> I'm pretty sure there are no FK constraints in all of Amarok.
>
> --Jeff
>

FK constraints would not help here anyway as we are deleting rows from
the child table.

Max


More information about the Amarok-devel mailing list