2.2 release

Casper van Donderen casper.vandonderen at gmail.com
Wed Aug 26 09:45:54 CEST 2009


Okay,

This small patch:

diff --git a/src/Systray.cpp b/src/Systray.cpp
index 46a1687..2be8b08 100644
--- a/src/Systray.cpp
+++ b/src/Systray.cpp
@@ -212,6 +212,10 @@ Amarok::TrayIcon::setupToolTip()

         tooltip += "</table>";

+        #ifdef Q_WS_WIN
+            QRegExp rx( "(<[^>]+>)" );
+            tooltip.replace( rx, "" );
+        #endif
         setToolTip( tooltip );
     }
     else

works for Amarok in stripping the tags. But this causes another
problem which I did not see before because it didn't fit:

Windows does not do multiline tooltips:
Kalimba by Mr. Scruff on Ninja TunaVolume: 80%Last Played: 14,482 days
agoLength: 5:48

This gives two options:
1) Insert spaces with #ifdef Q_WS_WIN.
2) Remove this extra info with an #ifndef Q_WS_WIN.

Opinions?

Casper

On Wed, Aug 26, 2009 at 9:05 AM, Casper van
Donderen<casper.vandonderen at gmail.com> wrote:
> I'll fix it in trunk & backport (if allowed) to 4.3. But that won't help yet since 4.2 is used.
>
> Casper
> ------Original Message------
> From: Ian Monroe
> To: amarok-devel at kde.org
> ReplyTo: amarok-devel at kde.org
> Subject: Re: 2.2 release
> Sent: Aug 26, 2009 03:53
>
> On Tue, Aug 25, 2009 at 6:40 PM, Dan Meltzer
> <parallelgrapefruit at gmail.com> wrote:
>>
>> The windows systray kde code should do a generic strip if possible,we
>> shouldn't need to carry two sets of strings.
>
> Ah good point. We should file a kdelibs bug, and then just go along
> with Casper's original solution.
>
> Ian
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>
>


More information about the Amarok-devel mailing list