[Amarok] Clean up the EngineController logic.

Ian Monroe ian.monroe at gmail.com
Sat Aug 22 14:48:26 CEST 2009


On Sat, Aug 22, 2009 at 4:37 AM, Alex Merry<kde at randomguy3.me.uk> wrote:
> I've figured out why it happens: EngineController no longer emits the
> engineStateChanged(Phonon::Playing, Phonon::Playing) notification when the
> track changes (because it's not a state change - this was a hack to make the
> window caption update).  Various places were incorrectly listening for this to
> tell them that a track changed.
>
> Things like the current track applet should be listening to engineNewMetdata
> instead (or as well as).  I'm going to fix the MainWindow caption and the
> context view stuff, but please bear this in mind in the future.  Particularly
> if you test with GStreamer, as GStreamer appears to emit state changes when
> the track changes (I'm guessing Playing->Buffering->Playing).
>
> Alex

Thanks for figuring this out, that state change stuff is really
annoying to work with. :)

Ian


More information about the Amarok-devel mailing list