[Amarok] Force on --as-needed.

Maximilian Kossick maximilian.kossick at googlemail.com
Sun Aug 2 12:36:01 CEST 2009


This commit breaks building on OS X for me. Reverting to the previous
flags works for me.

On Mon, Jul 27, 2009 at 10:12 PM, Jeff Mitchell<mitchell at kde.org> wrote:
> commit ef0d251381532902cbd81bfa7732358be3cecedb
> Author:     Jeff Mitchell <mitchell at kde.org>
> AuthorDate: Mon Jul 27 12:09:10 2009 -0400
> Commit:     Jeff Mitchell <mitchell at kde.org>
> CommitDate: Mon Jul 27 12:09:10 2009 -0400
>
>    Force on --as-needed.
>
>    Building from source tree is broken on some distros without --as-needed specified. Actually, it builds but it can't find collection plugins, which is bad. So force it on -- many distros are already doing this in
>    their packages.
>
>    Hopefully this won't cause issues for anyone -- if it does, we should see what the right resolution is (i.e. it might be fixing them, not reverting this, so don't revert blindly).
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 4278c90..9618829 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -153,5 +153,5 @@ if( WITH_UTILITIES )
>  endif( WITH_UTILITIES )
>
>  SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fmessage-length=0")
> -SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fmessage-length=0")
> +SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wl,--as-needed -fmessage-length=0")
>
>
>
>


More information about the Amarok-devel mailing list