ratings and scores use 0 for default value

Jeff Mitchell kde-dev at emailgoeshere.com
Sun Nov 30 16:04:27 CET 2008


Mark Kretschmann wrote:
> On Sun, Nov 30, 2008 at 2:17 AM, Caleb Cushing <xenoterracide at gmail.com> wrote:
>> https://bugs.kde.org/show_bug.cgi?id=172112
>>
>> unrated and unscored should be null values in the database, not having
>> them as null creates a problem when ever you want to set up a playlist
>> that includes greater than certain ratings or scores. and unrated
>> track should not be considered less than a rated track.
>>
>> sql wise this is as simple as making sure the default value when
>> creating tracks is null.
> 
> Well, do you have a patch for this? Otherwise I see no point in
> bringing up the topic here on the dev list.
> 

He brought it up here because I asked him to.  It will be harder to
change the sql schema after 2.0 than before it, so I thought we may want
to look at getting a fix in.

Probably, the fix is to either modify the schema or the query (so that
the query uses values of 0 as acceptable for all values > X).

The second one might be less intrusive and probably not that hard a fix
(Caleb, any help there?); the first fix would be more correct (unless it
would make our code more difficult elsewhere).

--Jeff


More information about the Amarok-devel mailing list