Standardizing Context Menu Actions

[Casey Link]

On Sun, Nov 2, 2008 at 9:53 PM, Dan Meltzer
<parallelgrapefruit at gmail.com> wrote:
> On Sun, Nov 2, 2008 at 9:44 PM, Casey Link <unnamedrambler at gmail.com> wrote:
>> On Sun, Nov 2, 2008 at 9:39 PM, Dan Meltzer
>> <parallelgrapefruit at gmail.com> wrote:
>>> On Sun, Nov 2, 2008 at 9:32 PM, Alejandro Wainzinger
>>> <aikawarazuni at gmail.com> wrote:
>>>> On Sun, Nov 2, 2008 at 6:45 PM, Dan Meltzer
>>>> <parallelgrapefruit at gmail.com> wrote:
>>>>> On Sun, Nov 2, 2008 at 8:40 PM, Seb Ruiz <ruiz at kde.org> wrote:
>>>>>> 2008/11/3 Dan Meltzer <parallelgrapefruit at gmail.com>:
>>>>>>> On Sun, Nov 2, 2008 at 7:57 PM, Alejandro Wainzinger
>>>>>>> <aikawarazuni at gmail.com> wrote:
>>>>>>>> The CollectionTreeView currently makes special cases of: editing tags
>>>>>>>> (EditCapability), Copy To Collection, Move To Collection,
>>>>>>>> CustomActionsCapability, etc.  But they all have the same idea in
>>>>>>>> mind: get a list of Meta::Track, and perform some actions on them.
>>>>>>>> What's desired is to refactor this so that the Collections, that the
>>>>>>>> selected tracks belong to, get tested for certain Capabilities, and
>>>>>>>> these Capabilities are all built in one go.  This also means making
>>>>>>>> certain Capabilities for Collection, instead of Track.
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> While I agree think that this is necessary, and we should do it, I
>>>>>>> think this definately needs to wait until after 2.0.  This sounds like
>>>>>>> a lot of code and changes, and has a possibility of introducing
>>>>>>> regressions.  In terms of implementation, I think the possibly best
>>>>>>> way to do this would be to make Collection inherit from Meta::Base (as
>>>>>>> It's really a type of meta).
>>>>>>
>>>>>> I disagree, I think this is of such importance that it needs to happen asap.
>>>>>
>>>>> The only real issue I've heard it cause so far is that people can only
>>>>> delete one track at a time from media devices.  This isn't great, but
>>>>> it's not a show stopper.  We can't keep deeming small issues
>>>>> showstoppers.  We've already delayed the release a lot for a lastfm
>>>>> bump that was completely unnecessary.  This is going to involve a lot
>>>>> of code changing.  It makes sense to put this off until we have time
>>>>> to let it get tested sufficiently.
>>>>
>>>> How about removing from local collection, MP3Tunes, etc.?
>>>
>>> Alt-F2 -> Dolphin.
>>
>>
>> Deleting from collection != Deleting on disk
>>
>> It can, but not necessarily so. Plus, you can't "Alt-F2 -> Dolphin" to
>> remove mp3tunes/ampache tracks.
>
> No, but we don't support removing tracks from ampache.  Are you
> suggesting we delay the release until vollmer implements that?
no

> Do we support removing tracks from mp3tunes currently anyways?
Yes, but there is no context action for it.

> I don't think deleting files from disk is implemented for local files either.
It is. See CollectionLocation. It has been ready for months :)

> Should we wait for these as well?
We don't need to, the most important one (local collection) is already
implemented.

Casey