Standardizing Context Menu Actions

Alejandro Wainzinger aikawarazuni at gmail.com
Mon Nov 3 03:32:36 CET 2008


On Sun, Nov 2, 2008 at 6:45 PM, Dan Meltzer
<parallelgrapefruit at gmail.com> wrote:
> On Sun, Nov 2, 2008 at 8:40 PM, Seb Ruiz <ruiz at kde.org> wrote:
>> 2008/11/3 Dan Meltzer <parallelgrapefruit at gmail.com>:
>>> On Sun, Nov 2, 2008 at 7:57 PM, Alejandro Wainzinger
>>> <aikawarazuni at gmail.com> wrote:
>>>> The CollectionTreeView currently makes special cases of: editing tags
>>>> (EditCapability), Copy To Collection, Move To Collection,
>>>> CustomActionsCapability, etc.  But they all have the same idea in
>>>> mind: get a list of Meta::Track, and perform some actions on them.
>>>> What's desired is to refactor this so that the Collections, that the
>>>> selected tracks belong to, get tested for certain Capabilities, and
>>>> these Capabilities are all built in one go.  This also means making
>>>> certain Capabilities for Collection, instead of Track.
>>>
>>> Hi,
>>>
>>> While I agree think that this is necessary, and we should do it, I
>>> think this definately needs to wait until after 2.0.  This sounds like
>>> a lot of code and changes, and has a possibility of introducing
>>> regressions.  In terms of implementation, I think the possibly best
>>> way to do this would be to make Collection inherit from Meta::Base (as
>>> It's really a type of meta).
>>
>> I disagree, I think this is of such importance that it needs to happen asap.
>
> The only real issue I've heard it cause so far is that people can only
> delete one track at a time from media devices.  This isn't great, but
> it's not a show stopper.  We can't keep deeming small issues
> showstoppers.  We've already delayed the release a lot for a lastfm
> bump that was completely unnecessary.  This is going to involve a lot
> of code changing.  It makes sense to put this off until we have time
> to let it get tested sufficiently.

How about removing from local collection, MP3Tunes, etc.?

>>
>>
>>
>> --
>> Seb Ruiz
>>
>> http://www.sebruiz.net/
>> http://amarok.kde.org/
>> _______________________________________________
>> Amarok-devel mailing list
>> Amarok-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/amarok-devel
>>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>


More information about the Amarok-devel mailing list