Fwd: extragear/multimedia/amarok/src/collectionbrowser

Seb Ruiz ruiz at kde.org
Sat Mar 8 16:24:20 CET 2008


Just making sure that Bonne reads this.

Is it safe to assume that everyone is subscribed to, and reads the
commit filter emails? (Probably not...)

---------- Forwarded message ----------
From: Maximilian Kossick <maximilian.kossick at googlemail.com>
Date: 8 Mar 2008 09:26
Subject: Re: extragear/multimedia/amarok/src/collectionbrowser
To: kde-commits at kde.org


This approach is unfortunately very broken. OrganizeCollection depends
 on the details of the collection and therefore has to be integrated
 into the collection, in particular into the collection's
 CollectionLocation. I think we need an isOrganizable method in
 CollectionLocation. If that method returns true (an ipod would be
 writeable, but not organizable, the local collection is both), we can
 just use two collectionLocations of the same collection instead of
 CollecetionLocations from different collections.


 On Fri, Mar 7, 2008 at 10:51 PM, Bonne Eggleston <b.eggleston at gmail.com> wrote:
 > SVN commit 783342 by bonne:
 >
 >  Start getting OrganizeCollection to work
 >
 >
 >   M  +48 -0     CollectionTreeView.cpp
 >   M  +1 -0      CollectionTreeView.h
 >   M  +194 -2    OrganizeCollectionDialog.cpp
 >   M  +1 -1      OrganizeCollectionDialog.h
 >   M  +315 -530  OrganizeCollectionDialogBase.ui
 >
 >
 >


-- 
Seb Ruiz

http://www.sebruiz.net/


More information about the Amarok-devel mailing list