extragear/multimedia/amarok/src/collection/sqlcollection

[Martin Aumueller]

In my opinion, Amarok should remember that the user manually set the cover for 
an album to 'no cover' and refrain from autofetching in that case. Even the 
cover manager should have a mode for not fetching covers for such albums.

But in general i consider it a good idea to autofetch covers for new albums.

Martin

On Saturday 21 June 2008, Dan Meltzer wrote:
> On 6/21/08, Maximilian Kossick <maximilian.kossick at googlemail.com> wrote:
> > didn't we try that last year already, for all albums in that case? My
> >  A2 still shows horribly wrong album art because of that little
> >  experiment (yes, I know that I could delete the cache). Are there any
> >  indications that the quality of album art delivered by the
> >  coverfetcher has improved in the meantime?
>
> Yes we did, and no it hasn't.
>
> We need to look at the parsing code in coverfetcher and figure out why
> it's oh so wrong before we can enable this.  That code scares me :)
>
> >  On Sat, Jun 21, 2008 at 1:05 PM, Seb Ruiz <ruiz at kde.org> wrote:
> >  > SVN commit 822755 by seb:
> >  >
> >  > Implement autofetching of images if there is no cover set and the
> >  > album is non-empty. Adding this as a preliminary test to get feedback
> >  > as to whether we want to include it by default. I'm going to say that
> >  > this can use a lot of optimizing, there are a few pathological cases
> >  > that I have thought of and haven't handled: - Cover auto-fetched, user
> >  > removes. Restart application, cover gets autofetched again.
> >  >
> >  >
> >  >  M  +8 -0      SqlMeta.cpp
> >  >
> >  >
> >  > ---
> >  > trunk/extragear/multimedia/amarok/src/collection/sqlcollection/SqlMeta
> >  >.cpp #822754:822755 @@ -21,6 +21,7 @@
> >  >  #include "Amarok.h"
> >  >  #include "BlockingQuery.h"
> >  >  #include "Debug.h"
> >  > +#include "covermanager/CoverFetcher.h"
> >  >  #include "covermanager/CoverFetchingActions.h"
> >  >  #include "mediadevice/CopyToDeviceAction.h"
> >  >  #include "meta/CustomActionsCapability.h"
> >  > @@ -931,6 +932,13 @@
> >  >         return QPixmap( result );
> >  >     }
> >  >
> >  > +    // Cover fetching runs in another thread. If there is a retreived
> >  > cover +    // then updateImage() gets called which updates the cache
> >  > and alerts the +    // subscribers. We use queueAlbum() because this
> >  > runs the fetch as a +    // background job and doesn't give an
> >  > intruding popup asking for confirmation +    if( !m_name.isEmpty() )
> >  > +        CoverFetcher::instance()->queueAlbum(
> >  > KSharedPtr<Meta::Album>(this) ); +
> >  >     // If the result image is empty then we didn't find any cached
> >  > image, nor // could we find the original cover to scale to the
> >  > appropriate size. Hence, // the album cannot have a cover, for any
> >  > size. In this case, we return the
> >
> >  _______________________________________________
> >  Amarok-devel mailing list
> >  Amarok-devel at kde.org
> >  https://mail.kde.org/mailman/listinfo/amarok-devel
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel