extragear/multimedia/amarok/src/collection

Maximilian Kossick maximilian.kossick at googlemail.com
Wed Jul 30 07:06:18 CEST 2008


While I can only guess at the reasons for this revert, did anybody
actually think about changing code that uses BQ to use signal/slots
instead? Blocking queries make a lot of sense imo inside SqlMeta or
NepomukMeta or any other Meta implementation, but those are not
limited to the QueryMaker API (they can use public methods provided by
their actual QM implementations instead).

It would help with our goal of achieving full network transparency in
A2 to make everything else in Amarok use the asynchronous API. Might
take a bit of refactoring though, but the result is going to be better
than to force every querymaker to support synchronous queries (which
*really* cannot be done for e.g. the ampache querymaker)

On Wed, Jul 30, 2008 at 5:47 AM, Daniel Caleb Jones
<danielcjones at gmail.com> wrote:
> SVN commit 839440 by djones:
>
> Revert the last 7 commits while we think through the blocking query problem some more.
>
>
>  M  +2 -50     MetaQueryMaker.cpp
>  M  +0 -11     MetaQueryMaker.h
>  M  +0 -123    QueryMaker.cpp
>  M  +0 -30     QueryMaker.h
>  M  +2 -3      nepomukcollection/NepomukAlbum.cpp
>  M  +2 -3      nepomukcollection/NepomukArtist.cpp
>  M  +2 -2      nepomukcollection/NepomukCollection.cpp
>  M  +75 -3     nepomukcollection/NepomukQueryMaker.cpp
>  M  +11 -5     nepomukcollection/NepomukQueryMaker.h
>  M  +5 -7      sqlcollection/OrganizeCollectionDialog.cpp
>  M  +19 -25    sqlcollection/SqlMeta.cpp
>  M  +14 -74    sqlcollection/SqlQueryMaker.cpp
>  M  +0 -9      sqlcollection/SqlQueryMaker.h
>  M  +21 -61    support/MemoryQueryMaker.cpp
>  M  +0 -7      support/MemoryQueryMaker.h
>  M  +0 -17     support/XmlQueryWriter.cpp
>  M  +0 -6      support/XmlQueryWriter.h
>
>
>


More information about the Amarok-devel mailing list