[PATCH] PopupDropper separator actions

Seb Ruiz ruiz at kde.org
Sat Jul 12 07:07:11 CEST 2008


Hi Jeff.
Apparently I don't have enough karma to commit to the popup dropper repository.

Here's a patch which allows popup dropper items in QMenus to render
properly as separators. It's important to notify the QAction about the
separator status otherwise the superclass won't have a clue when it is
downcast and the QAction is rendered in a menu/toolbar entry.

Once you've commit this, can you also please bump Amarok's pud version please?

Cheers,
seb


Index: PopupDropperAction.cpp
===================================================================
--- PopupDropperAction.cpp      (revision 829734)
+++ PopupDropperAction.cpp      (working copy)
@@ -177,6 +177,7 @@
 void PopupDropperAction::setSeparator( bool separator )
 {
     d->separator = separator;
+    QAction::setSeparator( separator );
 }

-- 
Seb Ruiz

http://www.sebruiz.net/


More information about the Amarok-devel mailing list