extragear/multimedia/amarok/src/meta

Daniel Winter dw at danielwinter.de
Thu Jul 10 03:48:13 CEST 2008


SVN commit 830269 by danielw:

disabled creating of MetaProxy::Track objects when collection manager can not return a track object. As long as Amarok not respects Track::isPlayable() it fixes a problem for me. i am not sure if it is needed anway. 

CCMAIL: amarok-devel at kde.org

 M  +7 -2      XSPFPlaylist.cpp  


--- trunk/extragear/multimedia/amarok/src/meta/XSPFPlaylist.cpp #830268:830269
@@ -160,7 +160,12 @@
         TrackPtr trackPtr = CollectionManager::instance()->trackForUrl( track.location );
         if ( trackPtr ){
             tracks << trackPtr;
-        } else {
+        }
+        // why do we need this? sqlplaylist is not doing this
+        // we don't want (probably) unplayable tracks
+        // and it causes problems for me (DanielW) as long
+        // amarok not respects Track::isPlayable()
+        /*else {
         
             MetaProxy::Track *proxyTrack = new MetaProxy::Track( track.location );
             {
@@ -176,7 +181,7 @@
             }
             tracks << Meta::TrackPtr( proxyTrack );
     //         tracks << CollectionManager::instance()->trackForUrl( track.location );
-        }
+        }*/
         
     }
     debug() << "returning " <<  tracks.size() << "tracks!";


More information about the Amarok-devel mailing list