[Patch] Fix collection tree crashes when handling compilations

[Nikolaj Hald Nielsen]

Nice job. As I am not really familiar with the code in question, I
will let Max look it over and commit it when he gets back online. Keep
up the good work! :-)

- Nikolaj

On Fri, Feb 29, 2008 at 7:09 PM, Aneurin Price <aneurin.price at gmail.com> wrote:
> This patch fixes crashes when editing tags for 'Various Artists' albums,
>  and when adding them to the playlist either by dragging or using the
>  context menu. As suggested by Max, the AlbumQueryMode is set to
>  OnlyCompilations when data() is null, in order to prevent the query
>  returning all other albums when the base 'Various Artists' entry is
>  selected.
>
>  Currently the track list returned when using the context menu is in a
>  seemingly random order. The order is as expected when dragging and
>  dropping, and I don't believe this is caused by this patch (seems to
>  happen sometimes for normal albums as well, but I haven't looked into why).
>
>  Since we have three identical code blocks here, I'm tempted to say it
>  should be refactored into one method, but for the moment I'm trying to
>  keep the changes to a minimum.
>
>  Thanks to Max and Nikolaj for the pointers.
>
>  - Nye
>
>
> _______________________________________________
>  Amarok-devel mailing list
>  Amarok-devel at kde.org
>  https://mail.kde.org/mailman/listinfo/amarok-devel
>
>