Maximilian Kossick maximilian.kossick at googlemail.com
Mon Dec 22 20:47:52 CET 2008

It looks like PrivateMetaRegistry is a a memory leak because nothing
gets ever deleted from the registry.

Regarding the new approach to playlist grouping, it might be a good
idea to reimplement operator== in subclasses. This would allow a lot
more flexible and powerful grouping in the playlist (e.g. grouping
tracks from different collections) than is possible by simply
comparing pointers. Another option (one which would not produce
side-effects, e.g. in hash maps) is to provide our own equals()
method, that can be used whenever we want to compare
tracks/abums/whatever and explicitly take the problem domain
(i.e.music) into account.


On Mon, Dec 22, 2008 at 7:46 PM, Nikolaj Hald Nielsen
<nhnFreespirit at gmail.com> wrote:
> SVN commit 900387 by nhnielsen:
> Add a very simple registry intended to be used by classes that create internal meta pointers so these can be shared instead of, for instance, each track having its very own album ptr, even though several tracks belong to the same album.
>  M  +1 -0      CMakeLists.txt
>  A             meta/PrivateMetaRegistry.cpp   [License: UNKNOWN]
>  A             meta/PrivateMetaRegistry.h   [License: UNKNOWN]
> --- trunk/extragear/multimedia/amarok/src/CMakeLists.txt #900386:900387
> @@ -205,6 +205,7 @@
>     meta/StreamInfoCapability.cpp
>     meta/UpdateCapability.cpp
>     meta/XSPFPlaylist.cpp
> +    meta/PrivateMetaRegistry.cpp
>     meta/file/File.cpp
>     meta/proxy/MetaProxy.cpp
>     meta/stream/Stream.cpp

More information about the Amarok-devel mailing list