Standardizing on using milliseconds or seconds in enginecontroller

[Mark Kretschmann]

On Sat, Dec 6, 2008 at 6:17 AM, Ian Monroe <ian at monroe.nu> wrote:
> On Fri, Dec 5, 2008 at 10:34 PM, Dan Meltzer
> <parallelgrapefruit at gmail.com> wrote:
>> I would really like to standardize on either using milliseconds or
>> seconds everywhere in EngineController.  Theres all sorts of room for
>> errors currently, and inconcistancy.  play() expects an offset in
>> milliseconds, but trackPosition() returns a time in seconds.  I'm not
>> sure which would be better to standardize on, however.  I'd lean to
>> milliseconds, but does anyone have a preference one way or the other?
>
> Milliseconds makes sense, since this is what Phonon uses.

Milliseconds, yes. I have a git branch where I started to convert it
some months ago.

But this is 2.1 material. Absolutely no reason to risk a regression
for 2.0.x releases.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org