Beautifying the nocover image in the currenttrack applet

Nikolaj Hald Nielsen nhnfreespirit at gmail.com
Thu Dec 4 08:37:26 CET 2008


Yeah, there seem to be an issue with several of these borders
sometimes being painted on top of each other. I have not had time to
look into it yet, but my guess would be that we somehow cache the
image with the border and then re-apply the border and cache it
again...

- Nikolaj

On Thu, Dec 4, 2008 at 4:50 AM, Casey Link <unnamedrambler at gmail.com> wrote:
> On Wed, Dec 3, 2008 at 9:08 PM, Seb Ruiz <ruiz at kde.org> wrote:
>> 2008/12/4 Big O <illogical1 at gmail.com>:
>>> On Wed, Dec 3, 2008 at 5:42 PM, Seb Ruiz <ruiz at kde.org> wrote:
>>>> 2008/12/4 Casey Link <unnamedrambler at gmail.com>:
>>>>> Attached is a patch that produces the following change in the
>>>>> currenttrack applet
>>>>>
>>>>> http://binaryelysium.com/images/Amarok_nocover_compare.png
>>>>>
>>>>> As far as I can tell there is no way to resize the currenttrack applet
>>>>> (yet), so this value will be fine until that changes. Also, if there
>>>>> is an actual cover it is still resized accordingly. If the actual
>>>>> cover > 156 then it will be downscaled - and still look good. If there
>>>>> actual cover is < 156 the it will be upscaled - and look not so good,
>>>>> but it has always been this way.
>>>>
>>>> Looks much better, you get my big rubber stamp of approval.
>>>>
>>> I'm either blind or looking at something totally different from all of
>>> you but the second image (the improvement yes?) looks worse than the
>>> first.
>>
>> Heh, no, the first image is the improvement.
>
> Actually no, the second image is the improvement. But the black border
> has nothing to do with my fix. The more tracks you play with no cover,
> the darker that border grows. If you play a track with a cover, then
> it resets.
>
> My change only affects the blurry-ness of the no cover image.
>
> Casey
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>


More information about the Amarok-devel mailing list