extragear/multimedia/amarok/src

Jeff Mitchell kde-dev at emailgoeshere.com
Mon Apr 28 12:34:10 CEST 2008


What's the reasoning for this?

Would it be better to use kfmclient and/or patch it to use xdg-open, and have 
it handle the foo on Windows?

--Jeff

On Monday 28 April 2008, Harald Sitter wrote:
> SVN commit 801925 by sitter:
>
> replace kfmclient with xdg-open, which will probably break on windows, but
> I guess we should use whatever function there is on windows to start the
> configured default browser
> CCMAIL: amarok-devel at kde.org
>
>
>  M  +1 -1      amarokcore/amarok.kcfg
>  M  +1 -1      configdialog/dialogs/GeneralConfig.cpp
>
>
> --- trunk/extragear/multimedia/amarok/src/amarokcore/amarok.kcfg
> #801924:801925 @@ -226,7 +226,7 @@
>      </entry>
>      <entry key="External Browser" type="String">
>          <label>Filename of the external web browser to be invoked by
> Amarok.</label> -        <default>kfmclient openURL</default>
> +        <default>xdg-open</default>
>      </entry>
>      <entry key="Collection Browser View Mode" type="Int">
>          <label>Whether the collection view is in the flat or tree view
> mode</label> ---
> trunk/extragear/multimedia/amarok/src/configdialog/dialogs/GeneralConfig.cp
>p #801924:801925 @@ -63,7 +63,7 @@
>  #ifdef Q_WS_MAC
>              "open"
>  #else
> -            "kfmclient openUrl"
> +            "xdg-open"
>  #endif
>        )
>      {
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel




More information about the Amarok-devel mailing list