Fwd: [PATCH] [RFC] Gigabeat S support / mtpmediadevice tweaks

[Seb Ruiz]

---------- Forwarded message ----------
From: Andrew Rodland <arodland at comcast.net>
Date: 7 Nov 2007 13:35
Subject: Re: [PATCH] [RFC] Gigabeat S support / mtpmediadevice tweaks
To: Seb Ruiz <ruiz at kde.org>


On Tuesday 06 November 2007 09:25:24 pm you wrote:
> Hi Andrew,
> I'll let the proper analysis be done by somebody with experience with
> MTP devices. Just a few things about your patch.
>
> 1 - please don't precede all your code with " // hobbs". It's quite
> meaningless.
>
That was so I could keep track of my changes -- I didn't start with an svn
checkout after all. Obviously I don't expect it to be included.

> 2 - please add some comments to the patch explaining what the code
> does and why (such as all those replace() calls
>
Can do... once I go back and figure out what it's all for. Unfortunately I let
the code sit for a little while before I sent it in ;)

> 3 - don't use sprintf(). Use i18n( "Disc %1" ).arg( discNumber ). This
> allows translations.
>
Can do.


-- 
Seb Ruiz

http://www.sebruiz.net/