Stars in the stable branch

[Alexandre Oliveira]

We could leave it as a config file only option.
It would reduce the number of people crying because it went away.
I don't like this kind of option myself, but we already have others
anyway (turning off dynamic collections, custom location for
collection.db, maybe others).

On 3/21/07, Jeff Mitchell <kde-dev at emailgoeshere.com> wrote:
> I realized after writing the previous mail that only the first one is
> necessary...setting CustomRatingsColors to false in (or removing it
> from) amarokrc is enough to get the yellow stars back.  Maybe I'll put
> something in the code to force-switch it back for people.
>
> --Jeff
>
> Jeff Mitchell wrote:
> > Mark--
> >
> > Should just be some cruft from the amarokrc -- for now at least I didn't
> > remove all the code, just really the stuff in the .ui file that displays
> > the config section so that the height of the dialog could be worked on
> > if someone wanted.  So at the moment the code is still in there, you
> > just can't activate it from within the GUI.  I removed the relevant
> > entries from my amarokrc and everything shows up yellow for me.  Remove:
> >
> > CustomRatingsColors
> > FixedHalfStarColor
> > StarColor[One,Two,Three,Four,Five,Half]
> >
> > from your amarokrc if they're in there and see if that fixes things for you.
> >
> > --Jeff
> >
> > Mark Kretschmann wrote:
> >
> >> Hey Jeff,
> >>
> >> after your removal of the colored stars config @ stable branch, my stars
> >> remain gray (instead of yellow). I assume this is because I had enabled the
> >> colored stars once, and now you've removed the configuration options, but the
> >> code is still in place?
> >>
> >> Should we worry about this or not?
> >>
> >>
> >>
> >
> > _______________________________________________
> > Amarok-devel mailing list
> > Amarok-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/amarok-devel
> >
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>