extragear/multimedia/amarok/src/podcasts

Martin Aumueller aumuell at reserv.at
Tue Jul 24 07:21:54 CEST 2007


On Sunday 22 July 2007, Bart Cerneels wrote:
> SVN commit 690980 by shanachie:
>
> Some improvements.
>
> Note: the Q_ASSERTS are here for debugging. I'll remove them when the code
> is stable.

IMHO, no need for removing them: it's a good way of documenting pre- and 
post-conditions. And probably the code is wrong anyway in some place if the 
assertion fails. And if the code is stable, it should get compiled 
with -DQT_NO_DEBUG, and then Q_ASSERT becomes a no-op.
>
>
>  M  +1 -0      PodcastCollection.cpp
>  M  +75 -259   PodcastMetaBase.cpp
>  M  +29 -106   PodcastMetaBase.h
>  M  +68 -47    PodcastReader.cpp
>  M  +3 -3      PodcastReader.h


More information about the Amarok-devel mailing list