extragear/multimedia/amarok/src/metadata/asf
Jeff Mitchell
kde-dev at emailgoeshere.com
Thu Dec 13 04:58:03 CET 2007
Do you know why we use TagLibFileName instead of TagLib::FileName like taglib
svn uses?
--Jeff
On Wednesday 12 December 2007, Shane King wrote:
> SVN commit 747833 by shakes:
>
> Compile fixes for svn taglib
>
>
> M +2 -3 taglib_asffiletyperesolver.cpp
> M +2 -1 taglib_asffiletyperesolver.h
>
>
> ---
> trunk/extragear/multimedia/amarok/src/metadata/asf/taglib_asffiletyperesolv
>er.cpp #747832:747833 @@ -27,12 +27,11 @@
>
> #include <string.h>
>
> -TagLib::File *ASFFileTypeResolver::createFile(const char *fileName,
> +TagLib::File *ASFFileTypeResolver::createFile(TagLibFileName fileName,
> bool readProperties,
> TagLib::AudioProperties::ReadStyle propertiesStyle) const
> {
> - const char *ext = strrchr(fileName, '.');
> - if(ext && (!strcasecmp(ext, ".wma") || !strcasecmp(ext, ".asf")))
> + if(CheckExtension(fileName, ".wma") || CheckExtension(fileName,
> ".asf")) {
> TagLib::ASF::File *f = new TagLib::ASF::File(fileName,
> readProperties, propertiesStyle); if(f->isValid())
> ---
> trunk/extragear/multimedia/amarok/src/metadata/asf/taglib_asffiletyperesolv
>er.h #747832:747833 @@ -25,13 +25,14 @@
> #ifndef TAGLIB_ASFFILETYPERESOLVER_H
> #define TAGLIB_ASFFILETYPERESOLVER_H
>
> +#include "../tfile_helper.h"
> #include <taglib/tfile.h>
> #include <taglib/fileref.h>
>
>
> class ASFFileTypeResolver : public TagLib::FileRef::FileTypeResolver
> {
> - TagLib::File *createFile(const char *fileName,
> + TagLib::File *createFile(TagLibFileName fileName,
> bool readAudioProperties,
> TagLib::AudioProperties::ReadStyle audioPropertiesStyle)
> const;
More information about the Amarok-devel
mailing list