Review Request 121264: Remove call to app.use(app.router); as documented here: https://github.com/strongloop/express/wiki/Migrating-from-3.x-to-4.x

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121264/#review71006
-----------------------------------------------------------


I have fixed the remaining issues and the server now starts again with express 4 .. will push shortly, including this patch. thanks!

- Aaron J. Seigo


On Nov. 27, 2014, 2:14 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121264/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 2:14 a.m.)
> 
> 
> Review request for Bodega and Marco Martin.
> 
> 
> Repository: bodega-server
> 
> 
> Description
> -------
> 
> Remove call to app.use(app.router); as documented here: https://github.com/strongloop/express/wiki/Migrating-from-3.x-to-4.x
> 
> 
> Diffs
> -----
> 
>   server/app.js 98eaa74bf1e58202036ee8afef2c173dbfeee08f 
> 
> Diff: https://git.reviewboard.kde.org/r/121264/diff/
> 
> 
> Testing
> -------
> 
> With this it doesn't give the error about app.router anymore. Still gives an error on startup as follows though:
> 
> body-parser deprecated bodyParser: use individual json/urlencoded middlewares app.js:80:9
> body-parser deprecated undefined extended: provide extended option node_modules/body-parser/index.js:85:29
> express-session deprecated undefined resave option; provide resave option app.js:82:9
> express-session deprecated undefined saveUninitialized option; provide saveUninitialized option app.js:82:9
> WARNING: Setting up server with no ssl!
> Bodega server listening on localhost:3000 in devel mode
> 
> events.js:72
>         throw er; // Unhandled 'error' event
>               ^
> Error: connect ECONNREFUSED
>     at errnoException (net.js:904:11)
>     at Object.afterConnect [as oncomplete] (net.js:895:19)
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20141127/ff09b38b/attachment.html>