Review Request 112965: add asset/forum/:assetId

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112965/#review40922
-----------------------------------------------------------


> Probably something is wrong here. It takes 3 seconds

indeed; have you done any profiling to see where the time is being used?


server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30063>

    externalUrl; incorrect.



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30065>

    why push the topics here, just to pull them out again one-by-one later in findPost? that seems extremely inefficient.
    
    is there any reason why you can't simply fetch the post for the topic right here?



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30064>

    why does it error if you run out of items in the array? it seems to me that this is a valid result: more posts were requested than exist, but that's not an error



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30061>

    externalUrl is wrong; bodega and discourse are not external to each other. this will cause the request to exit the local network and come back in through e.g.the load ballancer



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30060>

    externalUrl is wrong; bodega and discourse are not external to each other. this will cause the request to exit the local network and come back in through e.g.the load ballancer



server/lib/utils.js
<http://git.reviewboard.kde.org/r/112965/#comment30062>

    this is only used in forum.js, so put it there. util.js is for things that are used in more than one place.


- Aaron J. Seigo


On Sept. 27, 2013, 11:05 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112965/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 11:05 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> Add a new route which returns the messages from the forum.
> The json looks like this
> 
> {
>   "authStatus": true,
>   "device": "KDE-1",
>   "store": "KDE-1",
>   "points": 10000,
>   "success": true,
>   "topics": [
>     {
>       "title": "Foo bar linux12342425",
>       "message": "<p>foo bar linux123423235235235</p>"
>     },
>     {
>       "title": "Foo bar linux123424566",
>       "message": "<p>foo bar linux1234578896666</p>"
>     },
>     {
>       "title": "Foo bar linux1234245",
>       "message": "<p>foo bar linux12342245</p>"
>     },
>     {
>       "title": "Foo bar linux1234",
>       "message": "<p>foo bar linux1234566</p>"
>     },
>     {
>       "title": "Foo bar ioanna maria 1foo bar ioanna maria 1adsasd",
>       "message": "<p>88971238912389()(<em>()DAS</em>()A*(DS()<em>ADS(</em>()ADS908foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1</p>"
>     }
>   ]
> }
> 
> 
> Diffs
> -----
> 
>   server/doc/bodega.json 4efa14e 
>   server/lib/bodegadb.js 6d0c367 
>   server/lib/db/forum.js PRE-CREATION 
>   server/lib/utils.js e95b6ba 
>   server/routes.js f0be1b4 
>   server/test/forum.js PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112965/diff/
> 
> 
> Testing
> -------
> 
> $ make test/forum
> ./node_modules/.bin/mocha test/forum.js --reporter spec
> WARNING: Setting up server with no ssl!
> Bodega server listening on localhost:3001 in devel mode
> 
> 
>   Forum
>     Authorization
>       ? succeeds (75ms)
>     List Messages
>       ? should fail because the asset is invalid 
>       ? should succeed (3313ms) <------------------------------------------------------ Probably something is wrong here. It takes 3 seconds and both bodega-server and the forum are in localhost.
>                                                                                         I did this.timeout(15000) in order to pass the test
> 
>   3 passing (3 seconds)
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130927/9cb9a396/attachment-0001.html>