Review Request 112581: add support for the forum API

Aaron J. Seigo aseigo at kde.org
Thu Sep 12 15:52:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112581/#review39893
-----------------------------------------------------------


a button that opens a web browser to the forum page makes the application not self-hosting and very clumsy from a navigational POV (how do you get back to the client? pull down the peek area, close the browser and go back to the add-ons client? ugh)

rather, as discussed, it would be better to be able to show the last N (say, 5) comments in the assets info panel. as with reviews, it might make sense to have a link that says "See what people are saying.." or even just "See feedback..." which would then hide that link and expand to show the last N comments.

this itself could be done in one of two ways: either show the comments in the info pane itself or, and this is my preference atm, open a new column showing the feedback. that panel could then have a "Open the forum..." link that would open a web browser and which would be used to interact with the forum.

additionally, on the "rate and review" popup used to add / edit ratings, there should be a text area in which the user can put some text as a review which then gets added to the forum

really, the web forum part is only for the developer to continue interacting with the feedback and for people who wish to get more involved in the conversation to do so. but the Add Ons app itself should provide a basic display the feedback from the forum without leaving the add-ons app.

- Aaron J. Seigo


On Sept. 7, 2013, 5:46 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112581/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2013, 5:46 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch
> * parses the forum info from asset/:assetId
> * adds a button in the ui in order to open the link in the browser
> 
> 
> Diffs
> -----
> 
>   activeclient/package/contents/ui/storebrowser/AssetColumn.qml a678f16 
>   activeclient/src/bodegastore.cpp ba9dc27 
>   lib/bodega/assetjob.cpp 5f539cb 
>   lib/bodega/globals.h 5ab45da 
> 
> Diff: http://git.reviewboard.kde.org/r/112581/diff/
> 
> 
> Testing
> -------
> 
> attached screenshot
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/07/forumbutton.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130912/7cf55ec5/attachment.html>


More information about the Active mailing list