Review Request 112533: add ratings in the bodega-client
Giorgos Tsiapaliokas
terietor at gmail.com
Fri Sep 6 18:34:15 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112533/
-----------------------------------------------------------
(Updated Sept. 6, 2013, 6:34 p.m.)
Review request for Bodega.
Changes
-------
Also when the reload signal of the participantratingsmodel gets emitted,
the model won't repaint itself correctly(I have attached an image).
If I scroll the listview and it gets out of the window (add a lot of
ratings a scroll up or down) the listview will be ok
I have attached a diff with the code
of the reload signal. The reload signal must be used when the model need to take
the new data from the server(a rating gets deleted/created).
Description
-------
This patch implements the ratings feature
Diffs
-----
activeclient/package/contents/ui/SettingsPage.qml fb46eca
activeclient/package/contents/ui/settings/ParticipantRatings.qml PRE-CREATION
activeclient/package/contents/ui/storebrowser/AssetColumn.qml a678f16
activeclient/package/contents/ui/storebrowser/Ratings.js PRE-CREATION
activeclient/package/contents/ui/storebrowser/RatingsColumn.qml PRE-CREATION
activeclient/src/bodegastore.h 1e5aac5
activeclient/src/bodegastore.cpp ba9dc27
lib/bodega/CMakeLists.txt 8d382a7
lib/bodega/assetjob.h 5aab88c
lib/bodega/assetjob.cpp 5f539cb
lib/bodega/assetoperations.h 7ce7900
lib/bodega/assetoperations.cpp 9f9c2d5
lib/bodega/assetratingsjob.h PRE-CREATION
lib/bodega/assetratingsjob.cpp PRE-CREATION
lib/bodega/assetratingsjobmodel.h PRE-CREATION
lib/bodega/assetratingsjobmodel.cpp PRE-CREATION
lib/bodega/globals.h 5ab45da
lib/bodega/participantratingsjob.h PRE-CREATION
lib/bodega/participantratingsjob.cpp PRE-CREATION
lib/bodega/participantratingsjobmodel.h PRE-CREATION
lib/bodega/participantratingsjobmodel.cpp PRE-CREATION
lib/bodega/ratingattributesjob.h PRE-CREATION
lib/bodega/ratingattributesjob.cpp PRE-CREATION
lib/bodega/ratingsmodel_p.h PRE-CREATION
lib/bodega/ratingsmodel_p.cpp PRE-CREATION
lib/bodega/session.h d27d284
lib/bodega/session.cpp a7c7e94
lib/bodega/session_p.h ebefb4f
Diff: http://git.reviewboard.kde.org/r/112533/diff/
Testing
-------
check the attached images
File Attachments (updated)
----------------
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/ratings-main.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/participantratings.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/labelsnotcenter.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/delete2.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/brokenParticipant.diff
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/participantbroken.png
Thanks,
Giorgos Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130906/3bc58ae1/attachment.html>
More information about the Active
mailing list