Review Request 112965: add asset/forum/:assetId

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112965/#review41767
-----------------------------------------------------------


this patch is obviously not ready to go as it is full of debug output.

having looked at discourse a bit more today, my guess is that the reason it is taking so long to populate the requests with the call to findPost is that it is fast for listing topics, and fast enough for listing the comments in a topic ... but if you grab a lot of topics and their messages the time adds up and the result is a long wait for all the data to appear.

it appears that the most likely way to make this work acceptably well is going to be to simply return the topic titles by default and the user will have to request the content of the thread to see more. this follows the model discourse uses in its web interface as well.


server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30498>

    indentation is different



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30496>

    please remove all console.time calls



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30497>

    get rid of debug output



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30495>

    should not be there



server/lib/db/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30494>

    findPost is never called .. looks like this patch is a diff of the codebase still in devel and not an actual patch to be pushed.



server/test/forum.js
<http://git.reviewboard.kde.org/r/112965/#comment30493>

    timeout has already been increased for stripe tests; this should now be unnecessary


- Aaron J. Seigo


On Oct. 8, 2013, 3:17 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112965/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 3:17 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Repository: bodega-server
> 
> 
> Description
> -------
> 
> Add a new route which returns the messages from the forum.
> The json looks like this
> 
> {
>   "authStatus": true,
>   "device": "KDE-1",
>   "store": "KDE-1",
>   "points": 10000,
>   "success": true,
>   "topics": [
>     {
>       "title": "Foo bar linux12342425",
>       "message": "<p>foo bar linux123423235235235</p>"
>     },
>     {
>       "title": "Foo bar linux123424566",
>       "message": "<p>foo bar linux1234578896666</p>"
>     },
>     {
>       "title": "Foo bar linux1234245",
>       "message": "<p>foo bar linux12342245</p>"
>     },
>     {
>       "title": "Foo bar linux1234",
>       "message": "<p>foo bar linux1234566</p>"
>     },
>     {
>       "title": "Foo bar ioanna maria 1foo bar ioanna maria 1adsasd",
>       "message": "<p>88971238912389()(<em>()DAS</em>()A*(DS()<em>ADS(</em>()ADS908foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1</p>"
>     }
>   ]
> }
> 
> 
> Diffs
> -----
> 
>   server/config.json.sample 85b96d5 
>   server/doc/bodega.json 4efa14e 
>   server/lib/db/forum.js d4dde01 
>   server/lib/utils.js 221e98e 
>   server/test/forum.js PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112965/diff/
> 
> 
> Testing
> -------
> 
> $ make test/forum
> ./node_modules/.bin/mocha test/forum.js --reporter spec
> WARNING: Setting up server with no ssl!
> Bodega server listening on localhost:3001 in devel mode
> 
> 
>   Forum
>     Authorization
>       ? succeeds (75ms)
>     List Messages
>       ? should fail because the asset is invalid 
>       ? should succeed (3313ms) <------------------------------------------------------ Probably something is wrong here. It takes 3 seconds and both bodega-server and the forum are in localhost.
>                                                                                         I did this.timeout(15000) in order to pass the test
> 
>   3 passing (3 seconds)
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20131015/9383a2fa/attachment.html>