Review Request 110627: fix regression from commit 295d707e9deb15a3643c3e77a504336f50823956

Aaron J. Seigo aseigo at kde.org
Fri May 24 10:07:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110627/#review33082
-----------------------------------------------------------

Ship it!


since this regression affects code currently in master, please push this into master directly. thanks.

- Aaron J. Seigo


On May 24, 2013, 6:30 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110627/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 6:30 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> Hello,
> 
> this patch fixes the regression from the commit 295d707e9deb15a3643c3e77a504336f50823956 .
> The 295d707e9deb15a3643c3e77a504336f50823956 made the server unable to send confirmation emails.
> 
> 
> Diffs
> -----
> 
>   server/lib/db/register.js 9a63086 
>   server/lib/utils.js 1adcf9a 
> 
> Diff: http://git.reviewboard.kde.org/r/110627/diff/
> 
> 
> Testing
> -------
> 
> I have attached a screenshot in which I received an email during
> the registration.
> 
> For a mail server I used my gmail account and I started the
> server with 'node app.js'.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/confirmMail.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130524/dd685955/attachment.html>


More information about the Active mailing list