Review Request 110484: Bodega-server: Make the 404 page to render properly and fix an activation issue

Aaron J. Seigo aseigo at kde.org
Fri May 17 21:19:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110484/#review32715
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On May 17, 2013, 5:45 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110484/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 5:45 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> * The 404 page didn't render properly because the 404.jade include the index.jade and app.js doesn't send the proper information.
> * When you create a new account, and then you click on the activation link, the activation doesn't work, because the err is null,
>   so the err.message is throwing an exception. This is happening because the updateError get's the wrong Boolean type. 
> 
> 
> Diffs
> -----
> 
>   server/app.js 9f10778 
>   server/lib/db/confirm.js 9cd3384 
> 
> Diff: http://git.reviewboard.kde.org/r/110484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130517/2bd83481/attachment.html>


More information about the Active mailing list