Review Request 110287: fix some issues in the sql script and move away from the npm scripts functionality

Commit Hook null at kde.org
Sun May 12 21:03:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110287/
-----------------------------------------------------------

(Updated May 12, 2013, 9:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for Bodega.


Description
-------

Hello,

this patch does

1. it requires 3 parameters now instead of 1.
The new parameters are the config.json filepath, the sql dir and the sql command.
2. it removes the npm scripts functionality

check this issue https://github.com/isaacs/npm/issues/3370#issuecomment-16892283

3. it adds the sql functionality into the makefile.


Diffs
-----

  server/Makefile a35b309 
  server/package.json 3ee556d 
  sql/do_sql 93bf764 

Diff: http://git.reviewboard.kde.org/r/110287/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130512/1a51fcaa/attachment.html>


More information about the Active mailing list