Review Request 111162: Bodega-server: Add a test for puchasing an asset

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111162/#review34840
-----------------------------------------------------------


these two points:

* confirm points are properly distributed between store and asset owners
* confirm download records are correct

will have to be done with raw sql. see the after function in store.sql for an example of how to run sql from tests directly against the database. queries can be done to pull the relevant information and test against it.


server/test/purchase.js
<http://git.reviewboard.kde.org/r/111162/#comment25530>

    this should be made part of the `make test_data` run.. it should both process the testdata.sql file as well as copy over sets of test data into the appropriate location.


- Aaron J. Seigo


On June 21, 2013, 2:02 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111162/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 2:02 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> The test should check for the following:
>     
> * purchasing an asset the account does not have enough points for
> * purchase an asset the account does have enough points for
> * downloading the asset that was purchased
> * downloading an asset that costs points that was not purchased
> * downloading a free asset
> 
> Things that are missing:
> 
> * confirm points are properly distributed between store and asset owners
> * confirm download records are correct
> 
> 
> How can we verify the two above which are missing from the test?
> 
> 
> This addresses bug 320545.
>     http://bugs.kde.org/show_bug.cgi?id=320545
> 
> 
> Diffs
> -----
> 
>   server/lib/db/purchaseAsset.js 2613615 
>   server/test/purchase.js PRE-CREATION 
>   server/test/support/http.js 84a5fee 
>   sql/testdata.sql d151c17 
> 
> Diff: http://git.reviewboard.kde.org/r/111162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130621/6a107342/attachment.html>