Review Request 110892: Bodega-server: Add more error messages when an asset is failed to be purchased

Aaron J. Seigo aseigo at kde.org
Sat Jun 15 19:23:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110892/#review34395
-----------------------------------------------------------

Ship it!


one small issue left, then please push this once it is fixed (another round of review not necessary).

this should probably also be tested for in the test suite. :)


server/lib/errors.js
<http://git.reviewboard.kde.org/r/110892/#comment25266>

    this is now duplicated with InvalidAsset above


- Aaron J. Seigo


On June 15, 2013, 4:09 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110892/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 4:09 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> Hello,
> 
> With this patch, we will be able to know more information about why an asset has being failed to purchased.
> 
> 
> Diffs
> -----
> 
>   server/lib/db/purchaseAsset.js b01a652 
>   server/lib/errors.js 27fe443 
> 
> Diff: http://git.reviewboard.kde.org/r/110892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130615/5a4ebd6f/attachment.html>


More information about the Active mailing list