Review Request 111797: populate the assetinfo with ratings

Giorgos Tsiapaliokas terietor at gmail.com
Tue Jul 30 13:29:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111797/#review36805
-----------------------------------------------------------



server/lib/db/assetinfo.js
<http://git.reviewboard.kde.org/r/111797/#comment27160>

    Without distinct the query will return more
    than one results for asset that exists in 1 or more channels, so in the line 153 of assetInfo.js an error is returned.
    
    


- Giorgos Tsiapaliokas


On July 30, 2013, 1:26 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111797/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 1:26 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch populates the asset/:assetId with the # of ratings and the average rating.
> Docs and tests are also being included. 
> 
> 
> Diffs
> -----
> 
>   server/doc/bodega.json f973bda 
>   server/lib/db/assetinfo.js 9e3755d 
>   server/test/assetinfo.js e46387a 
>   sql/ratings.sql 841045f 
> 
> Diff: http://git.reviewboard.kde.org/r/111797/diff/
> 
> 
> Testing
> -------
> 
> my test passes
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130730/61bfcce7/attachment.html>


More information about the Active mailing list