Review Request 111369: add support for the collection in the active-addons

Giorgos Tsiapaliokas terietor at gmail.com
Tue Jul 16 14:48:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111369/
-----------------------------------------------------------

(Updated July 16, 2013, 2:48 p.m.)


Review request for Bodega.


Changes
-------

fix the issues.

a. MPL has been restored
b. the new roles in the model has been added
c. remove debug statements


Description
-------

This patch adds support for the collections in the active-addons.


Diffs (updated)
-----

  activeclient/package/contents/ui/storebrowser/ItemBrowser.qml 1ba83bf 
  activeclient/package/contents/ui/storebrowser/ListCollectionAssetsJobColumn.qml PRE-CREATION 
  activeclient/package/contents/ui/storebrowser/ListCollectionsJobColumn.qml PRE-CREATION 
  activeclient/package/contents/ui/storebrowser/OverviewColumn.qml 8befff5 
  activeclient/src/bodegastore.h a305d11 
  activeclient/src/bodegastore.cpp 78ded47 
  lib/CMakeLists.txt 381c03f 
  lib/bodega/CMakeLists.txt 1ecc498 
  lib/bodega/ballotaddassetjob.h 2447a46 
  lib/bodega/ballotaddassetjob.cpp 1fb425b 
  lib/bodega/ballotlistassetsjob.h 41e42cd 
  lib/bodega/ballotlistassetsjob.cpp 9492f25 
  lib/bodega/ballotremoveassetjob.h 7e6f2d3 
  lib/bodega/ballotremoveassetjob.cpp f50c112 
  lib/bodega/collectionaddassetjob.h PRE-CREATION 
  lib/bodega/collectionaddassetjob.cpp PRE-CREATION 
  lib/bodega/collectionlistassetsjob.h PRE-CREATION 
  lib/bodega/collectionlistassetsjob.cpp PRE-CREATION 
  lib/bodega/collectionlistassetsjobmodel.h PRE-CREATION 
  lib/bodega/collectionlistassetsjobmodel.cpp PRE-CREATION 
  lib/bodega/collectionremoveassetjob.h PRE-CREATION 
  lib/bodega/collectionremoveassetjob.cpp PRE-CREATION 
  lib/bodega/createballotjob.h d6f4de3 
  lib/bodega/createballotjob.cpp 01e2926 
  lib/bodega/createcollectionjob.h PRE-CREATION 
  lib/bodega/createcollectionjob.cpp PRE-CREATION 
  lib/bodega/deleteballotjob.h d6c53d2 
  lib/bodega/deleteballotjob.cpp d7cec5e 
  lib/bodega/deletecollectionjob.h PRE-CREATION 
  lib/bodega/deletecollectionjob.cpp PRE-CREATION 
  lib/bodega/globals.h 84fe9b8 
  lib/bodega/listballotsjob.h 30fc24b 
  lib/bodega/listballotsjob.cpp 00bf45c 
  lib/bodega/listcollectionsjob.h PRE-CREATION 
  lib/bodega/listcollectionsjob.cpp PRE-CREATION 
  lib/bodega/listcollectionsjobmodel.h PRE-CREATION 
  lib/bodega/listcollectionsjobmodel.cpp PRE-CREATION 
  lib/bodega/session.h 6491029 
  lib/bodega/session.cpp 6998da8 

Diff: http://git.reviewboard.kde.org/r/111369/diff/


Testing
-------

I have tested the active-addons with the testdata


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130716/62bdee90/attachment.html>


More information about the Active mailing list