Review Request 112095: add asset/participant/ratings/:assetId

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112095/#review38170
-----------------------------------------------------------



server/lib/db/ratings.js
<http://git.reviewboard.kde.org/r/112095/#comment28219>

    ASSET is not an SQL keyword; should therefore be lowercase



server/lib/db/ratings.js
<http://git.reviewboard.kde.org/r/112095/#comment28220>

    this should be moved to line 137 (it's unused in the case of an error, so don't spend CPU cycles creating it)



server/lib/db/ratings.js
<http://git.reviewboard.kde.org/r/112095/#comment28221>

    should be using utils.parseNumber and checking for > 0 in the if statement below



server/routes.js
<http://git.reviewboard.kde.org/r/112095/#comment28218>

    this should be merged with asset/participant/ratings above as:
    
    'asset/participant/ratings/:assetId?'
    
    this makes it consistent with other similar routes that optionally take a asset or other id that narrows the result set down.
    
    see the 'collection/list/:collectionId?' route for a pattern to follow


- Aaron J. Seigo


On Aug. 15, 2013, 7:11 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112095/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 7:11 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch adds the route asset/participant/ratings/:assetId
> which gives us the user's ratings for a specific asset.
> 
> 
> Diffs
> -----
> 
>   server/doc/bodega.json 3efd1cf 
>   server/lib/bodegadb.js 20a8ef8 
>   server/lib/db/ratings.js e5f4bed 
>   server/routes.js 903c9a3 
>   server/test/ratings.js 8538e86 
> 
> Diff: http://git.reviewboard.kde.org/r/112095/diff/
> 
> 
> Testing
> -------
> 
> the tests are passing
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130819/2052a6da/attachment.html>