Review Request 110103: add support for account deactivation
Aaron J. Seigo
aseigo at kde.org
Sat Apr 20 15:33:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110103/#review31335
-----------------------------------------------------------
server/app.js
<http://git.reviewboard.kde.org/r/110103/#comment23360>
the config file simply needs to be wellformed.
the problem with this replace is that settings with // in them will now break.
server/config.sample.json
<http://git.reviewboard.kde.org/r/110103/#comment23359>
just remove the comment.
sql/bodega.sql
<http://git.reviewboard.kde.org/r/110103/#comment23358>
isn't active the same thing as accountStatus?
- Aaron J. Seigo
On April 20, 2013, 3:08 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110103/
> -----------------------------------------------------------
>
> (Updated April 20, 2013, 3:08 p.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch adds support for account [de]activation.
>
> P.S.: Actually this patch contains 2 commits. The
> first one allows to use comments in the config.sample.json file.
> It was an overkill to open a second review
>
>
> This addresses bug 318251.
> http://bugs.kde.org/show_bug.cgi?id=318251
>
>
> Diffs
> -----
>
> server/app.js 9f10778
> server/config.sample.json 20a3161
> server/lib/db/changeAccountDetails.js 3db32fb
> server/lib/db/participantInfo.js 37817d4
> sql/bodega.sql 6504a9c
>
> Diff: http://git.reviewboard.kde.org/r/110103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130420/5e4b105b/attachment.html>
More information about the Active
mailing list