Review Request 109975: various fixes to sql scripts and package.json
Aaron J. Seigo
aseigo at kde.org
Sat Apr 20 13:23:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109975/#review31328
-----------------------------------------------------------
two small changes, and then this can go in. (unnecessary to post an update; once the comments below are addressed, push push push (yes marco!)
server/config.json
<http://git.reviewboard.kde.org/r/109975/#comment23348>
this file should not be added; config.sample.json is meant to be copied over.
sql/do_sql
<http://git.reviewboard.kde.org/r/109975/#comment23349>
vivaldi.sql should not be included by default.
- Aaron J. Seigo
On April 20, 2013, 10:03 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109975/
> -----------------------------------------------------------
>
> (Updated April 20, 2013, 10:03 a.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch does,
>
> * adds a sql/updates dir
> * impoves the setup.sh file
> * executes the sql/updates scripts before npm updates
> * populates the package.json
> ** adds a restriction to node
> ** overrides the default functionality of npm start
>
>
> Diffs
> -----
>
> README 7515b65
> server/config.json PRE-CREATION
> server/config.sample.json 16de381
> server/package.json e68c27c
> sql/do_sql PRE-CREATION
> sql/setup.sh 82cf22e
> sql/updates/README PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109975/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130420/a7573dcd/attachment-0001.html>
More information about the Active
mailing list