[Bug 308101] all Activities switcher thumbnails are the same; no new Activity can be selected

[Aaron J. Seigo]

https://bugs.kde.org/show_bug.cgi?id=308101

Aaron J. Seigo <aseigo at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kde-
                   |                            |runtime/b7f490bd6b6e0d12d60
                   |                            |573b4316e2931b0dc51f0
      Latest Commit|http://commits.kde.org/kde- |http://commits.kde.org/kde-
                   |runtime/b7f490bd6b6e0d12d60 |runtime/88463eabb8c45c91778
                   |573b4316e2931b0dc51f0       |f5d97991467e08dc28a53

--- Comment #3 from Aaron J. Seigo <aseigo at kde.org> ---
Git commit b7f490bd6b6e0d12d60573b4316e2931b0dc51f0 by Aaron Seigo.
Committed on 09/10/2012 at 11:17.
Pushed by aseigo into branch 'KDE/4.9'.

dataengine based models set their roles when setting the data, so respond to
that

syncRoleNames is fast (and faster now that we check that the role names
actually changed)
but it may be nicer to find a more efficient way in future than checking the
role names
on all / any data changes. in fact, the documentation for
QAbstractItemModel::setRoleNames says:

"This function must be called before the model is used.
 Modifying the role names after the model has been set may result in undefined
behaviour."

M  +5    -5    plasma/declarativeimports/core/datamodel.cpp

http://commits.kde.org/kde-runtime/b7f490bd6b6e0d12d60573b4316e2931b0dc51f0

--- Comment #4 from Aaron J. Seigo <aseigo at kde.org> ---
Git commit 88463eabb8c45c91778f5d97991467e08dc28a53 by Aaron Seigo.
Committed on 09/10/2012 at 11:17.
Pushed by aseigo into branch 'master'.

dataengine based models set their roles when setting the data, so respond to
that

syncRoleNames is fast (and faster now that we check that the role names
actually changed)
but it may be nicer to find a more efficient way in future than checking the
role names
on all / any data changes. in fact, the documentation for
QAbstractItemModel::setRoleNames says:

"This function must be called before the model is used.
 Modifying the role names after the model has been set may result in undefined
behaviour."

M  +5    -5    plasma/declarativeimports/core/datamodel.cpp

http://commits.kde.org/kde-runtime/88463eabb8c45c91778f5d97991467e08dc28a53

-- 
You are receiving this mail because:
You are on the CC list for the bug.