[kde-workspace] kwin/data/desktop: Move kwin/data to kwin/data/desktop so that I can add kwin/data/active.

[Lamarque V. Souza]

Em Tuesday 24 April 2012, Martin Gräßlin escreveu:
> On Tuesday 24 April 2012 05:58:16 Lamarque V. Souza wrote:
> > Em Monday 23 April 2012, Martin Gräßlin escreveu:
> > > Hi Lamarque,
> > 	
> > 	Hi,
> > 	
> > > I'm quite confused by your three commits [1, 2, 3]. Why are they
> > > needed? We
> > > nowhere in KWin have folder distinction for "desktop" and "active" and
> > > I do
> > > not like that at all.
> > 	
> > 	PA2 uses thumbnails as LayoutName, PA3 uses window_strip, we need to
> > 
> > change that when someone upgrades PA2 to PA3:
> > 
> > https://bugs.kde.org/show_bug.cgi?id=298285
> 
> First of all: if there is a bugfix you should add the bug id to your
> commit. This is really important as I outlined in my latest blog post [1]
> about how to use bugs.kde.org as a KDE developer :-)

	I usually do that, this time I did a "git merge" and forgot to do a "git 
commit --amend" afterwards.
 
> Another possibility would have been to extend the D-Bus interface used to
> activate the window switcher from the panel to specify which layout to use.
> This is clearly my preferred solution to this problem and would be useful
> in general and for other things. E.g. I want to have in the netbook shell
> the activation of Present Windows replaced with the new grid based window
> switcher layout. An adjustment here would have fixed this for both use
> cases.

	What would send the dbus call to select the layout in this case? The 
panel? The layout to use still needs to be saved somewhere or will it still be 
saved in kwinrc?
 
> > > Why did you push directly to master without consulting the KWin
> > > development
> > > team (no review request, no mail to mailing list, no ack in commits)?
> > 	
> > 	It looked a simple change and has been tested. Sorry for that, I will
> > 
> > open a review request next time.
> 
> <personal experience>I have often thought that a change is small or trivial
> and it bite my a** quite often. I can only recommend to have each of your
> changes reviewed - in all your projects you are involved. Given enough eyes
> all bugs shall be shallow. Having them fixed before hitting the source code
> is much better than afterwards</personal experience>

	Ok, noted.
 
> > > We also had some discussions about the update scripts in the past for
> > > active and found a bug in one of the scripts. So in case you just found
> > > some issues it would have been better to report a bug to fix it
> > > properly.
> > 	
> > 	The commits were in reponse to the bug reported above.
> 
> You can always add kwin to CC of bugs for active. That case we can help
> before code gets written :-)

	Ok. Talking about bugs related to kwin or code you wrote, there is this 
other one too: 

https://bugs.kde.org/show_bug.cgi?id=297068 (When shutting down via Lock 
Screen, the sleep countdown runs first)

https://bugs.kde.org/show_bug.cgi?id=291381 (Random black screenlocker)

	I commited some changes to branch screenlocker (kde-workspace) that 
fixed half of the problem described in #297068. You will probably want to 
review them.
 
> > > Overall I find that pretty uncool :-(
> > 	
> > 	Ok, sorry again.
> 
> No problem :-) We all make mistakes and we all are here to learn and
> improve. If you take from this experience that you should add
> BUG: 12354
> FIXED-IN: 4.9.0
> to your git commits, I'm more than happy :-)

	Ok.
 
> Overall I think the change needs to be reverted, as:
> * we will have one update script prepared for Beta 1
> * it seriously conflicts with a pending review I already did for PA
> * it breaks with existing schemes inside KWin
> * there are better ways to handle it (d-bus)

	Done.
 
> I would of course welcome if you work on the addition to d-bus. If you have
> any questions about it, I'm more than happy to give you some pointers about
> the code :-)

	I have the two questions I wrote above: 1. we still need to store the 
LayoutName somewhere, kwinrc is the logical place, will it still be used to 
strore LayoutName? 2. where the dbus call to change the layout will be issued?

-- 
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20120424/5cb07747/attachment.html>