[kde-workspace] kwin/data/desktop: Move kwin/data to kwin/data/desktop so that I can add kwin/data/active.

Thomas Lübking thomas.luebking at gmail.com
Tue Apr 24 11:48:41 UTC 2012


Am 24.04.2012, 10:58 Uhr, schrieb Lamarque V. Souza <lamarque at kde.org>:
> Em Monday 23 April 2012, Martin Gräßlin escreveu:

>> I'm quite confused by your three commits [1, 2, 3]. Why are they
> 	PA2 uses thumbnails as LayoutName, PA3 uses window_strip, we need to
> change that when someone upgrades PA2 to PA3:
>
> https://bugs.kde.org/show_bug.cgi?id=298285

The commits somewhat "conflict" with pending  
https://git.reviewboard.kde.org/r/104299/
In general changing the directory structure is always a bold move and  
probably not even required or the best solution here
(aside the other review one could have simply ifdef'd the script in  
question or alter it's behavior at runtime)

>> Why did you push directly to master without consulting the KWin
>  It looked a simple change and has been tested.
Such would be "git rm clients/oxygen" - nevertheless it would certainly  
cause some stir, yesno? ;-)

In general we (and that explicitly includes Martin as maintainer) actually  
pass most stuff through reviewboard - keeps everyone up-to-date and  
prevents conflicting approaches.
Also two heads are better than none (-: :-)

Cheers,
Thomas


More information about the Active mailing list