[kde-workspace] kwin/data/desktop: Move kwin/data to kwin/data/desktop so that I can add kwin/data/active.

[Thomas Pfeiffer]

On 24.04.2012 10:58, Lamarque V. Souza wrote:
> Em Monday 23 April 2012, Martin Gräßlin escreveu:
>
>  > Hi Lamarque,
>
> Hi,
>
>  > I'm quite confused by your three commits [1, 2, 3]. Why are they needed? We
>
>  > nowhere in KWin have folder distinction for "desktop" and "active" and I do
>
>  > not like that at all.
>
> PA2 uses thumbnails as LayoutName, PA3 uses window_strip, we need to change that
> when someone upgrades PA2 to PA3:
>
> https://bugs.kde.org/show_bug.cgi?id=298285
>
>  > Why did you push directly to master without consulting the KWin development
>
>  > team (no review request, no mail to mailing list, no ack in commits)?
>
> It looked a simple change and has been tested. Sorry for that, I will open a
> review request next time.
>
>  > We also had some discussions about the update scripts in the past for
>
>  > active and found a bug in one of the scripts. So in case you just found
>
>  > some issues it would have been better to report a bug to fix it properly.
>
> The commits were in reponse to the bug reported above.
>
>  > Overall I find that pretty uncool :-(
>
> Ok, sorry again.

Since I was the one who filed the bug Lamarque mentioned, I feel I should 
provide some context here.
The situation is such: A few weeks ago, the repository which is used by default 
on the Plasma Active 2 Meego image provided by basyskom was updated to package 
versions which worked well with newly created Testing images.
However, when I updated an existing PA 2 image, I noticed the bug mentioned by 
Lamarque which was caused by an entry in kwinrc that doesn't work with the new 
KWin version on Plasma Active.
Now the problem was that end users which used the PA2 Meego image would have a 
broken Task Switcher after doing a regular update, which severely affects the 
whole system. This was a situation we needed to fix urgently. Therefore, 
Lamarque did somewhat of a quick-fix to the problem, which worked for Plasma 
Active, but obviously wasn't exactly an elegant solution from the KWin team's 
point of view.
With the help of the KWin team, probably a more elegant solution could have been 
found. Our lesson learned was that from now on, we will do upgrade tests before 
merging changes to the Stable repository, so we can avoid creating situations 
where we need to find solutions in a hurry because they affect live users.
So I hope situations like this can be avoided in the future.

Cheers,
Thomas